Device query updates #658
Merged
Device query updates #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified with/without this commit and the code looks OK to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versioned DSOs
We really shouldn't ever load unversioned DSOs because you shouldn't need dev files to run any application. I ran into this issue when using
nvidia-docker, which doesn't includelibnvidia-ml.soby default.Displaying GPU memory
We could just display CUDA info only - there's no clear reason to call NVML here - but I have a vague recollection of CUDA being unable to query the memory available for newer, fancier GPUs sometimes. So I'm just adding it as a fallback path.
I can't test this on Windows, but I've attempted to preserve @crohkohl's changes from #199.